Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): enforce unique table names across types #2736

Merged
merged 14 commits into from
Apr 25, 2024
Merged

fix(store): enforce unique table names across types #2736

merged 14 commits into from
Apr 25, 2024

Conversation

yonadaa
Copy link
Contributor

@yonadaa yonadaa commented Apr 25, 2024

fixes #2710

@yonadaa yonadaa requested review from alvrs and holic as code owners April 25, 2024 13:51
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7bf0f2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@latticexyz/store Patch
@latticexyz/cli Patch
@latticexyz/dev-tools Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
mock-game-contracts Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yonadaa yonadaa requested review from ludns and qbzzt as code owners April 25, 2024 14:29
@yonadaa yonadaa requested a review from holic April 25, 2024 15:00
@holic holic changed the title feat(store): table ID is unique on namespace and name fix(store): table ID is unique on namespace and name Apr 25, 2024
holic
holic previously approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like need to regenerate docs but otherwise lgtm!

@holic
Copy link
Member

holic commented Apr 25, 2024

waiting for @alvrs sign off too, since this is a protocol bump

alvrs
alvrs previously approved these changes Apr 25, 2024
View reviewed changes
@holic holic dismissed stale reviews from alvrs and themself via 746f0b5 April 25, 2024 17:42
@holic holic changed the title fix(store): table ID is unique on namespace and name fix(store): enforce unique table names across types Apr 25, 2024
@holic holic merged commit ed404b7 into main Apr 25, 2024
12 checks passed
@holic holic deleted the yonadaaa/unique-namespace-name branch April 25, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic approved these changes

@alvrs alvrs alvrs left review comments

@ludns ludns Awaiting requested review from ludns ludns is a code owner

@qbzzt qbzzt Awaiting requested review from qbzzt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

registerTable should check for existence of table ID for both table types
3 participants
@yonadaa @holic @alvrs